Tyriar
Follow
Pinned
7,103 contributions in the last year
Activity overview
Contribution activity
August 2022
Created 97 commits in 6 repositories
Created a pull request in microsoft/vscode that received 14 comments
Add ligature support to terminal take 3
Fixes #34103 Supersedes #139537 This adds an experimental ligatures setting, this will get us self hosting on the ligatures addon without any addit…
+311
−104
•
14
comments
Opened 37 other pull requests in 4 repositories
microsoft/vscode
1
open
25
merged
- Add debug logs around auto replies
- Collapse 3+ spaces into middle ellipsis
- Escape go to dirs with spaces properly
- Swallow copy zsh script error to allow multi-user machines
- Update xterm
- Handle multiple key handlers in extended pwsh keybindings
- Send IsWindows when running bash shell integration on Windows
- Fix windows reconnecting to the wrong pty
- Add .fish to shell script language
- Finalize TerminalExitReason API
- Clarify 633 E sequence
- Finalize VS Code shell integration sequences in code
- Use %s to format % chars instead of sed to sanitize
- Avoid null coalescing operator for pwsh 6 support
- [1.70] Escape % in bash and zsh shell integration
- [1.70] Fix pwsh shell integration tests
- Fix pwsh shell integration tests
- Improved reconnection logging and throw when attaching to orphan processes
- [1.70] Ignore pwsh shell integration script errors on Windows
- Escape % in bash and zsh shell integration
- Ignore pwsh shell integration script errors on Windows
- Remove shell decoration icon settings
- Move IReconnectionTaskData into contrib/tasks
- Pass progress type along in notification updates
- Upgrade to xterm.js v5 beta
- Some pull requests not shown.
xtermjs/xterm.js
5
merged
1
open
microsoft/vscode-docs
4
merged
microsoft/vscode-wiki
1
merged
Reviewed 56 pull requests in 6 repositories
microsoft/vscode
25 pull requests
- wait for terminal reconnection to try to reconnect tasks
- enable adding and navigating to custom marks in the buffer
- allow recent commands to be pinned
- wait for trust to be initialized before prompting in tasks
- use correct setting value for auto run tasks
- improve task reconnection
- reset user's ZDOTDIR if shell integration is disabled
- better fix for complex debug traps
- improve fish shell integration in vi mode
-
🎁 Support other terminals CWD escape sequence - disable shell integration for complex debug trap
- Fixes #154643 by always rendering the checkbox in the viewport
- Swallow copy zsh script error to allow multi-user machines
- use task map key
- Update grammars
- Fix invalid tree item check for iconPath
- Fix invalid tree item check for iconPath
- Fix fish integration script when commandline is empty
- Fix Simplify bash PROMPT_COMMAND handling commit
- add shell integration script for fish
- use alias for command
- Clarify 633 E sequence
- skip task terminals when startup kind is not reload
-
support debug traps that contain
[[ -
handle debug traps with
[[specially - Some pull request reviews not shown.
xtermjs/xterm.js
4 pull requests
microsoft/vscode-wiki
3 pull requests
microsoft/node-pty
2 pull requests
xtermjs/xtermjs.org
1 pull request
microsoft/vscode-docs
1 pull request
Created an issue in microsoft/vscode that received 13 comments
New comment overlay is distracting
I often develop while I have a draft PR, the way these new buttons show up is a lot of distracting noise, especially when selecting multiple lines.…
13
comments
Opened 43 other issues in 5 repositories
microsoft/vscode
18
open
14
closed
- It's very hard to use SCM gutter decoration with new comment button
- SCM decorations are single pixel wide and sometimes not visible at all
- Support SGR ANSI escape sequences in quick pick labels
- Soft layer breaker: Terminal should not be mentioned in SimpleFindWidget
- Terminal go to recent directory should standardize path formats
- Windows -> Windows remote links with single result still open the search
- The sticky header shadow should remain when it's being scrolled off the screen
- Sometimes the terminal loads with the wrong color set
- Shell integration: Prioritize OSC 633 over other protocols
-
Shell integration: Support
OSC 9 ; 9 ; <cwd> STfor CWD on Windows -
Shell integration: Support
OSC 7 ; scheme://cwd STfor updating cwd -
Shell integration: Support
OSC 1337 ; CurrentDir=<cwd> STfor updating cwd - Shell integration: bash and zsh don't serialize \n and ; characters
- IsWindows is set on Linux and macOS's pwsh shell integration script
- Avoid escaping % in shell integration scripts
- Tasks started when not focused do not end up getting displayed
- Clicking stick headers should provide some context above and highlight the resulting destination
- Sign pwsh shell integration script
- clipboard-read denied when using webview clipboard API
- Revealing in editor is not aware of sticky lines
- Let me ctrl/cmd+click symbols in the sticky header
- Multiple of the same sticky header appeared
- Sticky scroll header shows when the rest of the function is out of view
- Ambiguous characters warn about box drawing \ but not / or |
- Terminal powerline rendering is getting its edge clipped
- Some issues not shown.
xtermjs/xterm.js
6
open
1
closed
- Different foreground color in dom vs webgl when using min contrast ratio
- Support links with multiple ranges
- Double clicking CJK words does ignores the first cell
- Selection doesn't render correctly for ligatures (webgl only)
- Some ligatures seem to overlap
- Update peer dependency to 5
- Inactive selection isn't working correctly if it contains transparency
microsoft/vscode-codicons
2
closed
rangav/thunder-client-support
1
open
microsoft/vscode-docs
1
open
83
contributions
in private repositories
Aug 1 – Aug 17
