close
The Wayback Machine - https://web.archive.org/web/20230527140436/https://github.com/mattermost/mattermost-server/pull/21430
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-37933] Channel preference to auto-follow all threads in the channel #21430

Merged
merged 15 commits into from May 5, 2023
Merged

[MM-37933] Channel preference to auto-follow all threads in the channel #21430

merged 15 commits into from May 5, 2023

Conversation

vish9812
Copy link
Contributor

@vish9812 vish9812 commented Oct 17, 2022 •
edited

Summary

Create the thread membership whenever there is a reply on a post.

Ticket Link

JIRA - https://mattermost.atlassian.net/browse/MM-37933

Release Note

Added a new option to auto-follow all threads in the Channel's Notification Preference.

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 17, 2022
@vish9812 vish9812 added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester labels Oct 18, 2022
@mattermod
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

koox00
koox00 previously approved these changes Oct 20, 2022
View reviewed changes
@koox00 koox00 added 3: QA Review Requires review by a QA tester and removed 3: QA Review Requires review by a QA tester labels Oct 20, 2022
@mattermod
Copy link
Contributor

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/253021

ashishbhate
ashishbhate previously approved these changes Oct 21, 2022
View reviewed changes
@ashishbhate ashishbhate removed the 2: Dev Review Requires review by a developer label Oct 21, 2022
@ashishbhate
Copy link
Contributor

Added a new option to auto-follow all threads in the Channel's Notification Preference.

AFAIK, the frontend for this feature hasn't been built yet.
Is the PR not going to be merged until the frontend is done? If we're going to merge this PR early, then we need to change (or remove) the release note.

@esethna
Copy link
Contributor

esethna commented Oct 21, 2022

@Willyfrog ^

@Willyfrog
Copy link
Contributor

Good catch @ashishbhate
Yes we should remove it until it is accesible.
@AshishDhama remember to add it to your PR when you add the UI for this

@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 28, 2022
@jgilliam17
Copy link

jgilliam17 commented Oct 28, 2022 •
edited

Thank you @vish9812
I checked E2E report - looks good, no PR related failures
Let me know when I can test the actual menu options on the test server? thanks 🙂

@vish9812 vish9812 added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Oct 31, 2022
@vish9812
Copy link
Contributor Author

/update-branch

@AshishDhama AshishDhama mentioned this pull request Nov 2, 2022
Closed
@vish9812
Copy link
Contributor Author

vish9812 commented Nov 8, 2022

/update-branch

koox00
koox00 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@koox00 koox00 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪, btw do we need to have the feature behind a feature flag?

@koox00 koox00 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 25, 2023
@koox00 koox00 removed the 2: Dev Review Requires review by a developer label Apr 26, 2023
@vish9812
Copy link
Contributor Author

@furqanmlk It's up for review.

@stevemudie
Copy link

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@vish9812
Copy link
Contributor Author

vish9812 commented May 1, 2023

/update-branch

@vish9812
Copy link
Contributor Author

vish9812 commented May 3, 2023

Hey @stevemudie is it looking good to merge?

@stevemudie
Copy link

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@stevemudie stevemudie added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels May 4, 2023
@mm-cloud-bot
Copy link

Creating a new SpinWick test server using Mattermost Cloud.

@mm-cloud-bot
Copy link

Mattermost test server created! 🎉

Access here: https://mattermost-server-pr-21430.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

@stevemudie
Copy link

Hey @stevemudie is it looking good to merge?

@vish9812 Sorry for the delay. I wasn't able to get the E2E tests to complete prior to today but they have now and I'm looking the results over next. After that I just need to test it out on the Spinwick and it should be good to go.

It shouldn't be long! 😄

stevemudie
stevemudie approved these changes May 4, 2023
View reviewed changes
Copy link

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vish9812 This is all set!

@stevemudie stevemudie added QA Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester labels May 4, 2023
@vish9812 vish9812 added 4: Reviews Complete All reviewers have approved the pull request and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels May 5, 2023
@mm-cloud-bot
Copy link

Test server destroyed

@vish9812 vish9812 merged commit d860548 into master May 5, 2023
29 checks passed
@vish9812 vish9812 deleted the MM-37933_auto-follow branch May 5, 2023 06:39
@amyblais amyblais added Docs/Needed Requires documentation Changelog/Done Required changelog entry has been written labels May 5, 2023
@amyblais amyblais added this to the v8.0.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostaspt kostaspt kostaspt approved these changes

@koox00 koox00 koox00 approved these changes

@stevemudie stevemudie stevemudie approved these changes

@AshishDhama AshishDhama AshishDhama approved these changes

@ashishbhate ashishbhate ashishbhate left review comments

Assignees

@furqanmlk furqanmlk

@vish9812 vish9812

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation QA Review Done QA review is completed but other reviews are outstanding (exception to usual process) release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet