Changeset 61098

Timestamp:

10/30/2025 07:43:13 PM (4 months ago)

Author:

joedolson

Message:

Media: Prevent fatal error if metadata is an array.

Check the data type of ID3 data on import before running wp_kses_post or wp_kses_post_deep to fix a fatal error thrown when attempting to run wp_kses_post on non-string content in PHP 8.2+.

Adds unit tests to verify.

Props sllimrovert, ankitkumarshah, rollybueno, wpfy, hmbashar, SirLouen, johnbillion, huzaifaalmesbah, sandeepdahiya, sourabhjain, poojapadamad, joedolson.
Fixes #63529.

Location:

trunk

Files:

• src/wp-admin/includes/media.php (modified) (1 diff)
• tests/phpunit/tests/media/wpAddId3TagData.php (added)

trunk/src/wp-admin/includes/media.php

@@ -3535 +3535 @@
             foreach ( $data[ $version ]['comments'] as $key => $list ) {
                 if ( 'length' !== $key && ! empty( $list ) ) {
-                    $metadata[ $key ] = wp_kses_post( reset( $list ) );
+                    $metadata[ $key ] = is_array( $list ) ? wp_kses_post_deep( reset( $list ) ) : wp_kses_post( $list );
                     // Fix bug in byte stream analysis.
                     if ( 'terms_of_use' === $key && str_starts_with( $metadata[ $key ], 'yright notice.' ) ) {