Changeset 61866

Timestamp:

03/08/2026 11:47:58 PM (5 days ago)

Author:

SergeyBiryukov

Message:

Code Quality: Correct hook registration type mismatches.

Though add_action() and add_filter() are functionally equivalent internally, for proper semantics the former should be used on actions and the latter on filters.

Follow-up to [37920], [38046], [53266].

Props apermo.
Fixes #64828.

Location:

trunk/src

Files:

• wp-admin/includes/admin-filters.php (modified) (2 diffs)
• wp-includes/default-filters.php (modified) (1 diff)

trunk/src/wp-admin/includes/admin-filters.php

@@ -54 +54 @@
 // Prerendering.
 if ( ! is_customize_preview() ) {
-    add_filter( 'admin_print_styles', 'wp_resource_hints', 1 );
+    add_action( 'admin_print_styles', 'wp_resource_hints', 1 );
 }
 
@@ -86 +86 @@
 add_filter( 'heartbeat_settings', 'wp_heartbeat_set_suspension' );
 
-add_action( 'use_block_editor_for_post_type', '_disable_block_editor_for_navigation_post_type', 10, 2 );
+add_filter( 'use_block_editor_for_post_type', '_disable_block_editor_for_navigation_post_type', 10, 2 );
 add_action( 'edit_form_after_title', '_disable_content_editor_for_navigation_post_type' );
 add_action( 'edit_form_after_editor', '_enable_content_editor_for_navigation_post_type' );

trunk/src/wp-includes/default-filters.php

@@ -386 +386 @@
 // Login actions.
 add_action( 'login_head', 'wp_robots', 1 );
-add_filter( 'login_head', 'wp_resource_hints', 8 );
+add_action( 'login_head', 'wp_resource_hints', 8 );
 add_action( 'login_head', 'wp_print_head_scripts', 9 );
 add_action( 'login_head', 'print_admin_styles', 9 );