close
Skip to content

Latest commit

 

History

History
83 lines (48 loc) · 2.62 KB

how-to-get-your-pull-request-reviewed.md

File metadata and controls

83 lines (48 loc) · 2.62 KB

How To Get Your Pull Request Reviewed?

Sometimes we publish a Pull Request and no one reviews our work. What to do?

Attracting a review largely isn't about the code – it is about making the reviewing easy.

If you published a Pull Request that isn't getting any comments or reviews, try one of the strategies used by core contributors:

Create the smallest reasonable PRs

Approving a 2000-line-long PR takes months and feels overwhelming.

Approving a 50-line long PR takes days or hours and feels easy.

Large batches slow you down. Ship your work in small chunks to merge more and learn faster.

Share relevant context:

Clarify:

  • What problem are you solving?
  • How does your PR solve it?
  • What feedback do you need?
  • What’s out of scope?
  • What’s unintuitive?
  • How to test?

Summarize any related issues and PRs.

It's easier than asking others to go and figure it out.

Make your PR exciting

All contributions are competing for attention. Make your stand out.

The easiest way? Say why it matters:

❌ A new react hook to get data ✅ useEntityRecord: get data with 10x less boilerplate

Then prove it with code examples, visuals, and screencasts.

Show your work

Post a link to your PR in related issues & PRs.

Ping commenters of related issues, previous committers, and tech leads.

Bring it up on the #core-editor channel of the WordPress.org slack. The easiest way to get feedback is to speak out during the open floor section of the weekly Core Editor meeting.

Assign relevant labels, milestones, and projects (or ask someone).

Review the work of others

It’s the easiest way to get on others’ radar.

Look up the PRs of commenters of related issues, previous committers, and tech leads. Then review them.

Is their work unfamiliar? Do:

  • Take some time to understand it
  • Propose a pair programming session
  • Skip, go for the next PR

Reduce risk with clarity

Risk adds friction – an approval can backfire later.

Clarity is like grease. Clearly document:

  • What risks are involved? Why take them?
  • Why is this PR the best solution?
  • How can the risk be minimized?
  • What else has been tried?

Follow the attention

Some PRs naturally get more traction than others.

Double down on these.

Some Issues are more topical than others (e.g. those listed in the goals for an upcoming release) and thus will garner more attention. By focusing on these it will be easier to attract reviewers.

How to get there quickly? Help with an active project from the WordPress roadmap