Changeset 14707

Timestamp:

03/13/2026 06:35:07 AM (14 hours ago)

Author:

dd32

Message:

Plugin Directory: Resolve a PHP Deprecation notice in the Cron listings for creation of dynamic properties.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-manager.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-manager.php

@@ -424 +424 @@
         }
 
+        // Convert to stdClass to avoid dynamic property deprecation on Job objects.
+        $jobs = array_map( static fn( $job ) => (object) (array) $job, $jobs );
+
         // Fetch logs for the tasks.
         if ( $with_logs ) {
             $log_table = str_replace( 'jobs', 'logs', \HM\Cavalcade\Plugin\Job::get_table() );
-            foreach ( $jobs as &$job ) {
-                // Fetch logs for the task.
+            foreach ( $jobs as $job ) {
                 $job->logs = $wpdb->get_results(
                     $wpdb->prepare(
@@ -445 +447 @@
         // Sort jobs based on last run.
         usort( $jobs, static function( $a, $b ) {
-            $a_last_log = 0;
-            $b_last_log = 0;
-            if ( $a->logs ) {
-                $a_last_log = max( array_map( 'strtotime', wp_list_pluck( $a->logs, 'timestamp' ) ) );
-            }
-            if ( $b->logs ) {
-                $b_last_log = max( array_map( 'strtotime', wp_list_pluck( $b->logs, 'timestamp' ) ) );
-            }
-
-            $a_last_log = max( $a->start, $a_last_log );
-            $b_last_log = max( $b->start, $b_last_log );
-
-            return $a_last_log <=> $b_last_log;
+            $a_last = max( $a->start, ! empty( $a->logs ) ? max( array_map( 'strtotime', wp_list_pluck( $a->logs, 'timestamp' ) ) ) : 0 );
+            $b_last = max( $b->start, ! empty( $b->logs ) ? max( array_map( 'strtotime', wp_list_pluck( $b->logs, 'timestamp' ) ) ) : 0 );
+
+            return $a_last <=> $b_last;
         } );