Changeset 61830

Timestamp:

03/04/2026 08:40:32 PM (9 days ago)

Author:

westonruter

Message:

Build/Test Tools: Integrate TypeScript into the core development workflow.

This introduces a new GitHub Action workflow for JavaScript type checking, mirroring the implementation for PHPStan in #61175. It also adds a typecheck:js Grunt task and includes it in the precommit:js task list. Only files related to the code editor are initially checked with TypeScript, with the expectation that additional files will be added to the files list in tsconfig.json as a part of ongoing maintenance work, for example #64238 and #64226.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/11131

Follow up to r61699, r61800, r61539.

Props westonruter, jonsurrell.
See #61175, #64661, #48456.
Fixes #64662.

Location:

trunk

Files:

• .github/workflows/javascript-type-checking.yml (added)
• .github/workflows/phpstan-static-analysis.yml (modified) (1 diff)
• .github/workflows/reusable-javascript-type-checking.yml (added)
• Gruntfile.js (modified) (2 diffs)

trunk/.github/workflows/phpstan-static-analysis.yml

@@ -82 +82 @@
     steps:
       - name: Dispatch workflow run
-        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
         with:
           retries: 2

trunk/Gruntfile.js

@@ -1557 +1557 @@
         'webpack:prod',
         'jshint:corejs',
+        'typecheck:js',
         'uglify:imgareaselect',
         'uglify:jqueryform',
@@ -2010 +2011 @@
     grunt.registerTask( 'test', 'Runs all QUnit and PHPUnit tasks.', ['qunit:compiled', 'phpunit'] );
 
+    grunt.registerTask( 'typecheck:js', 'Runs TypeScript type checking.', function() {
+        var done = this.async();
+
+        grunt.util.spawn( {
+            cmd: 'npm',
+            args: [ 'run', 'typecheck:js' ],
+            opts: { stdio: 'inherit' }
+        }, function( error ) {
+            done( ! error );
+        } );
+    } );
+
     grunt.registerTask( 'phpstan', 'Runs PHPStan on the entire codebase.', function() {
         var done = this.async();