close
Skip to content

Embed block: replace twitter icon with x icon#65580

Closed
chrisbellboy wants to merge 1 commit intoWordPress:trunkfrom
chrisbellboy:feat/embed-block-twitter-icon
Closed

Embed block: replace twitter icon with x icon#65580
chrisbellboy wants to merge 1 commit intoWordPress:trunkfrom
chrisbellboy:feat/embed-block-twitter-icon

Conversation

@chrisbellboy
Copy link
Contributor

@chrisbellboy chrisbellboy commented Sep 23, 2024

What?

Changes the Twitter icon in the twitter variation of the Embed block to the X icon.

Why?

The twitter variation in the embed block was still using the Twitter icon.

How?

This changes the title, description, and icon attributes of the Twitter variation.

As the title attribute is no longer Twitter, two new keywords were also added (x and twitter) so the twitter variation remains easily searchable.

The actual variation name remains twitter, since changing this would cause issues for existing Twitter/X embeds.

Testing Instructions

  1. Edit a post or page.
  2. Embed a tweet by either:
    • Pasting a Twitter/X URL into an empty Paragraph block.
    • Adding a new Embed block and pasting the Twitter/X URL into it.
    • Adding the Twitter/X Embed block variation directly.

Screenshots or screencast

image image

Related: #55142

@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: chrisbellboy <chrisdotdotdot@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad
Copy link
Contributor

Thanks for the PR and sorry for missing it. We're landing it here #73110 and I added you to the props.

@youknowriad youknowriad closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants