Embed block: replace twitter icon with x icon#65580
Embed block: replace twitter icon with x icon#65580chrisbellboy wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the PR and sorry for missing it. We're landing it here #73110 and I added you to the props. |
What?
Changes the Twitter icon in the
twittervariation of the Embed block to the X icon.Why?
The
twittervariation in the embed block was still using the Twitter icon.How?
This changes the
title,description, andiconattributes of the Twitter variation.As the title attribute is no longer
Twitter, two new keywords were also added (xandtwitter) so thetwittervariation remains easily searchable.The actual variation name remains
twitter, since changing this would cause issues for existing Twitter/X embeds.Testing Instructions
Screenshots or screencast
Related: #55142