Remove focused playwright test so all tests run; fix broken tests#2194
Merged
sarayourfriend merged 5 commits intomainfrom May 25, 2023
Merged
Remove focused playwright test so all tests run; fix broken tests#2194sarayourfriend merged 5 commits intomainfrom
sarayourfriend merged 5 commits intomainfrom
Conversation
|
Size Change: 0 B Total Size: 849 kB ℹ️ View Unchanged
|
Contributor
Author
|
Reverting settings does not fix the issue :( |
Member
|
@WordPress/openverse-frontend Drafting this while I look at the failing tests. |
…ay/pause click" test
Member
|
@WordPress/openverse-maintainers unless there's some flaky tests I missed, all tests are now passing locally for me so I've marked it ready for review. Please review this if you are able; the second approver should merge if no changes are needed. |
| }) | ||
|
|
||
| test.only("should open audio results as links", async ({ page }) => { | ||
| test("should open audio results as links", async ({ page }) => { |
Collaborator
There was a problem hiding this comment.
Oh dear.
We should add an ESLint restricted syntax rule to prevent this from happening.
{
"selector": "CallExpression > MemberExpression:matches([object.name=/(test|it|describe)/], [object.object.name=/(test|it|describe)/])[property.name='only']",
"message": "Do not commit .only"
}
{
"selector": "CallExpression > MemberExpression[object.object.name='it'][object.property.name='only']",
"message": "Do not commit .only"
}That appears to work when I test it locally for *.only, *.only.each and *.concurrently.only which are all the iterations I could find on the jest documentation.
dhruvkb
approved these changes
May 25, 2023
Member
dhruvkb
left a comment
There was a problem hiding this comment.
LGTM, the ESLint changes can be a separate issue and PR if merging this is urgent.
sarayourfriend
approved these changes
May 25, 2023
Collaborator
|
Good point @dhruvkb, I'll open a separate PR for it and merge this one with our approvals now 👍 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2191 by @obulat 🤞
Description
This PR reverts the changes to the Playwright config introduced in #1920 in an attempt to fix Playwright e2e tests.I do not understand what in these changes makes Playwright not find all of the tests. @sarayourfriend, do you have an idea?We missed the
.onlyadded in one of the tests, which caused Playwright to only run that one test...Testing Instructions
Check the CI Playwright e2e tests log - it should have around 155 tests (instead of 1).
Locally, you can use
just frontend/run test:playwright -- e2eto run the tests.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin