close
Skip to content

Use tallies redis DB for thumbnail tallies#2257

Merged
sarayourfriend merged 1 commit intomainfrom
feature/use-tallies-db
Jun 1, 2023
Merged

Use tallies redis DB for thumbnail tallies#2257
sarayourfriend merged 1 commit intomainfrom
feature/use-tallies-db

Conversation

@AetherUnbound
Copy link
Collaborator

Description

Fast-follow to #2243 to use the tallies Redis DB instead of the default one. The values being tracked here are for analysis reasons and so it makes sense to move them to that DB, particularly since the key prefixes have also changed.

Testing Instructions

Testing steps for #2243 should also apply, you'll just need to use -n 3 in the redis-cli call to indicate you're connecting to the tallies database.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner June 1, 2023 01:06
@AetherUnbound AetherUnbound added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Jun 1, 2023
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AetherUnbound AetherUnbound added 🟥 priority: critical Must be addressed ASAP and removed 🟧 priority: high Stalls work on the project or its dependents labels Jun 1, 2023
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarayourfriend sarayourfriend merged commit bc2dc9c into main Jun 1, 2023
@sarayourfriend sarayourfriend deleted the feature/use-tallies-db branch June 1, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants