Conversation
dhruvkb
approved these changes
Aug 29, 2023
Member
dhruvkb
left a comment
There was a problem hiding this comment.
LGTM, same as before. I have one suggestion about waiting for the containers to be up but I won't block on it.
6cecc0c to
e6de8cd
Compare
AetherUnbound
approved these changes
Aug 31, 2023
Collaborator
AetherUnbound
left a comment
There was a problem hiding this comment.
LGTM and works with just catalog/init on its own!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
An inconvenience of having to turn up the whole stack for testing catalog-only changes.
Description
This PR adapts the
load_sample_data.shscript to accept an option for only loading the upstream DB data. Luckily the script was modular enough to make this a pretty easy change. Kudos to @dhruvkb here! This way the API command can continue working as usual.Testing Instructions
Run the new command and try querying the upstream DB to see it's filled. This process returns zero results in
main.Also, confirms the
just recreateandjust api/recreatecommands continue working as expected.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin