fulldecent
Follow
fulldecent
Follow
Achievements
Achievements
Highlights
Pinned
2,248 contributions in the last year
Less
More
Activity overview
Contributed to
su-squares/tenthousandsu.com,
su-squares/student-list,
TreasureProject/treasure-marketplace-contracts
and 5 other
repositories
Contribution activity
March 2022
Created 42 commits in 8 repositories
Created 5 repositories
- fulldecent/sablier JavaScript
- fulldecent/analytics-quarry-web Python
- fulldecent/public-disclosures
- fulldecent/treasure-marketplace TypeScript
- fulldecent/wtf-html-css CSS
Created a pull request in TreasureProject/treasure-marketplace-contracts that received 2 comments
This combines createListing and updateListing
Fixes #17, fixes #18 Notes that affect the application: Previously, the contract had an undocumented feature where existing listings could not be …
+50
−80
•
2
comments
Opened 19 other pull requests in 5 repositories
TreasureProject/treasure-marketplace-contracts
11
merged
3
closed
- Update naming and NatSpec per Solidity style guide, fixes #24, fixes #19
- Fix minor fixes
- Optimize Listings storage, fixes #10
- WIP Fix everything
- Add test for token approval after marking not approved
- Fix Hardhat inaccurate uncovered lines reporting
- Fix max fee
- Do not allow changing payment token
- Allow admin to select token type
- Use IERC20 for payment token
- Use allow list wording, fixes #11
- Remove unspecified magic expirationDate, fixes #21
- Allow to cancelListing even if paused
- Add tests to package.json
freescout-helpdesk/freescout
1
open
1
closed
wikimedia/analytics-quarry-web
1
closed
ethereum/public-disclosures
1
merged
mdo/wtf-html-css
1
merged
Reviewed 12 pull requests in 2 repositories
TreasureProject/treasure-marketplace-contracts
11 pull requests
ethereum/solidity
1 pull request
Created an issue in sc-forks/solidity-coverage that received 4 comments
Uncovered lines counting lines that are covered
I have a smart contract and testing setup. With the command: hardhat coverage --testfiles 'contracts/MY_CONTRACT.sol' it is showing several lines u…
4
comments
Opened 37 other issues in 9 repositories
TreasureProject/treasure-marketplace-contracts
24
closed
- Document deployment and burn-in testing procedures
- Transaction can still go through after NFT is removed from allow list
- Treasure Marketplace Contract Review ac31264
- Code does not follow the Solidity style guide
- _buyItem implementation is fragile to reentrancy
- Missing unchained initializer
- Expiration times can be much longer than specified
- Missing upgradability gap
- Opportunities for inlining code
- There is no meaningful difference between createListing and updateListing
- updateListing does not allow to increase price
- Owner can harm sellers by pausing contract
- Seller unable to cancel listing
- Updating the payment token changes the commitments on behalf of sellers without their consent
- NFT registration could obviate need for using ERC-165 introspection
- Unsemantic reference to payment token
- Deprecated wording
- Gas inefficient storage of listings
- Solidity version is unsupported
- Owner can rugpull hard with upgrade
- Package management uses ranges
- Owner may steal customer NFTs
- Owner may frontrun and take 100% of fees
- NatSpec documentation is missing
freescout-helpdesk/freescout
4
open
2
closed
primitivefinance/primitive-dodoc
1
open
NomicFoundation/hardhat
1
closed
chiru-labs/ERC721A
1
closed
OpenZeppelin/openzeppelin-contracts-upgradeable
1
closed
TreasureProject/treasure-marketplace
1
closed
fulldecent/Nineteen-Eighty-Five
1
open
gakonst/foundry
1
closed
18
contributions
in private repositories
Mar 1 – Mar 18
