Possible logic error in wp_trim_excerpt()

[theMikeD]

https://core.trac.wordpress.org/browser/tags/5.7/src/wp-includes/formatting.php#L3845

Reading this code, it looks like the wp_trim_excerpt filter's $raw_excerpt parameter will be empty if $text as supplied to the function is empty. This should be the value of $text at L3824 should it not? Or do I mis-understand?

This PR assigns the correct value for $raw_excerpt if the passed $text is empty. Right now $raw_excerpt is empty if $text is empty.

Trac ticket: https://core.trac.wordpress.org/ticket/52820

[donmhico]

Hello @theMikeD. Thanks for the ticket. Yes, I believe you're correct. $raw_excerpt passed to wp_trim_excerpt filter is empty if $text is empty. In my PR above, I placed $raw_excerpt = $text; below the apply_filter( 'the_content' ) because I still believe that $raw_excerpt should be processed by that filter. Others can chime in their thoughts regarding this.

[hellofromTonya]

Today is 5.8 Beta 1. Ran out of time for this one to land. Punting to 5.9.

[audrasjb]

We have some conflicts to resolve in the above PR. As today is 5.9 beta 1, I think it's safer to move this ticket to 6.0 to ensure it's properly reviewed and fixed.

Trac ticket: https://core.trac.wordpress.org/ticket/52820

[jrf]

Replying to theMikeD:

https://core.trac.wordpress.org/browser/tags/5.7/src/wp-includes/formatting.php#L3845

Reading this code, it looks like the wp_trim_excerpt filter's $raw_excerpt parameter will be empty if $text as supplied to the function is empty. This should be the value of $text at L3824 should it not? Or do I mis-understand?

I do agree there may be a logic error in this function, but I don't necessarily think it's in the filter. Maybe we should have good look at what this function is supposed to do ?

From the docblock:

3798 	 * Generates an excerpt from the content, if needed.
3799	 *
3800	 * Returns a maximum of 55 words with an ellipsis appended if necessary.
...
3808	 * @param string             $text Optional. The excerpt. If set to empty, an excerpt is generated.
3809	 * @param WP_Post|object|int $post Optional. WP_Post instance or Post ID/object. Default null.
3810	 * @return string The excerpt.

Looking at the code, the excerpt is only trimmed to 55 words when it has been auto-generated, not when it was provided via the $text parameter.

Is this really the intended behaviour ?

[costdev]

As this is still being discussed and we're approaching RC1, I'm going to move this ticket to Future Release.

[SirLouen]

Replying to jrf:

Looking at the code, the excerpt is only trimmed to 55 words when it has been auto-generated, not when it was provided via the $text parameter.

Is this really the intended behaviour ?

It appears that this concern was not addressed. I'm adding 2nd-opinion for this as it seems it's not a reporter trouble.

[SirLouen]

Also last patch in PR2541 needs refresh.