PHP/RestrictedPHPFunctions: update error message to focus on security risk#2703
Closed
rodrigoprimo wants to merge 1 commit intoWordPress:developfrom
Closed
PHP/RestrictedPHPFunctions: update error message to focus on security risk#2703rodrigoprimo wants to merge 1 commit intoWordPress:developfrom
rodrigoprimo wants to merge 1 commit intoWordPress:developfrom
Conversation
… risk Remove the reference to create_function() being deprecated/removed from PHP, as that is PHPCompatibility's domain, and instead focus on the security risk it poses.
Collaborator
Author
|
Closing as I missed #2702 before creating this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the error message for the
create_functiongroup to focus on the security risk instead of referencing PHP deprecation/removal, as that is PHPCompatibility's domain.This was suggested by @jrfnl in #2693 (review).
@jrfnl, is this more or less what you had in mind, or do you prefer a different approach?
Suggested changelog entry
WordPress.PHP.RestrictedPHPFunctions: improved the clarity of the error message for the error triggered whencreate_functionis found.Related issues/external references
#2693 (review)