i18n: Localise content attribute of the Read More block#810
Merged
Conversation
Contributor
Author
|
Thanks for the review @mikachan. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #807.
The
contentattribute of the Read More block (<!-- wp:read-more {"content":"..."} /-->) was not being localised when exporting a block theme. This addscore/read-moreto theget_localizable_block_attributes()map introduced in #788, alongside a corresponding test case.Changes
includes/create-theme/theme-locale.php— addcore/read-more => ['content']toget_localizable_block_attributes()tests/CbtThemeLocale/escapeBlockAttributes.php— add test case for the Read More blockcontentattributeTesting
Tested manually via WP Playground CLI with the local plugin mounted. Added a Read More block with a custom label, saved changes to theme, and confirmed the exported file contains
<?php esc_attr_e('...', 'theme-slug');?>in place of the plain string.Note: This is my first PR for this repo, and I leaned on Claude for research and testing.