ToggleGroupControl: apply animation only when interacting with toggle

[simison]

What problem does this address?

Toggle button has a nice animation when toggling, but the animation gets applied also when something else in the surrounding UI changes location of the toggle on the screen:

Screen.Recording.2024-01-09.at.13.12.43.mov

Note how changing other settings causes toggle animation to lag. That said, collapsing panels doesn't cause the same effect, so I'm not entirely sure what's in play here.

What is your proposed solution?

Apply animation only onChange, and disable otherwise.

[mirka]

Are you able to provide some minimal repro code? At some point we fixed the issue of unwanted animations like this, so what you're seeing is probably a particular case. Like you mentioned, it doesn't usually happen on normal layout shifts, for example when toggling the hideLabelFromVision prop.

[github-actions]

Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks.

[github-actions]

Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks.

[mirka]

I'm assuming this will be fixed by #59642. Please re-open if not!

[tyxla]

Thanks for connecting the dots, @mirka, I didn't realize there was an open issue about it. And yes, that's exactly the one we were fixing.