Closed
Conversation
spacedmonkey
reviewed
Dec 8, 2022
2 tasks
hellofromtonya
requested changes
Dec 8, 2022
Contributor
hellofromtonya
left a comment
There was a problem hiding this comment.
Block this PR until the architectural redesign is completed and merged. (See my comment here #46398 (comment) for more context.) Once merged, then can revisit what changes are needed in this PR, if any.
Contributor
|
This PR is now unblocked. It will need to be rebased and rebuilt to apply the enhancement to the newly designed Fonts API (which is now in |
Contributor
|
This PR was applied to the old API. It will not work with the new API. I think it's best to close this PR, but use it as reference for the intent. Then open a new PR to add the enhancement to the new API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Solves #46398
Adds support for
nameattribute inwp_register_webfonts:Why?
I'm describing use case in detail at #46398, but essentially to match how
theme.jsonalready works.How?
Allows passing
nameattribute as part of font family array.I'm not entirely happy with solution as conceptually "Name" would belong to higher up, not necessarily inside font-family definition. I also didn't see better alternative.
Testing Instructions
Add this to mu-plugins or elsewhere:
Open site editor and note font families:
Testing Instructions for Keyboard
Screenshots or screencast