Conversation
fluiddot
commented
Jan 30, 2024
Comment on lines
+8
to
+9
| UI_AUTOMATOR_2_VERSION="2.32.3" | ||
| XCUITEST_VERSION="5.7.0" |
Contributor
Author
There was a problem hiding this comment.
These versions are the ones I had locally installed. So far, they haven't produced incompatibilities. In the future, we might consider updating them if necessary.
geriux
approved these changes
Jan 30, 2024
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Nice work! I've confirmed it uninstalls other versions correctly (if they exist) and installs the expected ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Set fixed versions of Appium drivers to address failures in Android E2E tests encountered after merging #58274.
Why?
Fixes and re-enables Android E2E tests.
How?
Appium drivers are cached using the checksum of the
package-lock.jsonfile (reference). This implies that when this file is modified, the Appium drivers are installed. However, we are installing the most recent version which might be incompatible with the current Appium version as it can be read in the Appium CLI documentation ofupdatecommand:The usage of different versions can be seen in the CI jobs of release PRs:
2.42.2=> Android E2E tests passed ✅.2.43.1=> Android E2E tests failed ❌.For this reason, we are setting a fixed version for Appium drivers to address potential issues when running E2E tests.
Additionally, this PR reverts #58376 to re-enable Android E2E tests.
Testing Instructions
React Native E2E Tests (Android)CI job succeeds.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A