Remove media collection bridge functions#59547
Merged
Conversation
2 tasks
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
13 tasks
fluiddot
commented
Mar 4, 2024
Comment on lines
-271
to
-273
| export function mediaSaveSync() { | ||
| return RNReactNativeGutenbergBridge.mediaSaveSync(); | ||
| } |
| * @param {Array<Map>} mediaFiles the mediaFiles attribute of the block, containing data about each media item. | ||
| * @param {string} blockClientId the clientId of the block. | ||
| */ | ||
| export function requestMediaFilesEditorLoad( mediaFiles, blockClientId ) { |
| * | ||
| * @param {Array<Map>} mediaFiles the mediaFiles attribute of the block, containing data about each media item | ||
| */ | ||
| export function requestMediaFilesFailedRetryDialog( mediaFiles ) { |
| * | ||
| * @param {Array<Map>} mediaFiles the mediaFiles attribute of the block, containing data about each media item | ||
| */ | ||
| export function requestMediaFilesUploadCancelDialog( mediaFiles ) { |
| * | ||
| * @param {Array<Map>} mediaFiles the mediaFiles attribute of the block, containing data about each media item. | ||
| */ | ||
| export function requestMediaFilesSaveCancelDialog( mediaFiles ) { |
| * @param {Array<Map>} mediaFiles the mediaFiles attribute of the block, containing data about each media item. | ||
| * @param {string} blockClientId the clientId of the block. | ||
| */ | ||
| export function mediaFilesBlockReplaceSync( mediaFiles, blockClientId ) { |
Comment on lines
-300
to
-305
| func gutenbergDidRequestMediaSaveSync() {} | ||
| func gutenbergDidRequestMediaFilesEditorLoad(_ mediaFiles: [[String: Any]], blockId: String) { } | ||
| func gutenbergDidRequestMediaFilesFailedRetryDialog(_ mediaFiles: [[String: Any]]) { } | ||
| func gutenbergDidRequestMediaFilesUploadCancelDialog(_ mediaFiles: [[String: Any]]) { } | ||
| func gutenbergDidRequestMediaFilesSaveCancelDialog(_ mediaFiles: [[String: Any]]) { } | ||
| func gutenbergDidRequestMediaFilesBlockReplaceSync(_ mediaFiles: [[String: Any]], clientId: String) {} |
Contributor
Author
There was a problem hiding this comment.
These functions are optional, only gutenbergDidRequestMediaFilesEditorLoad is actually implemented in the host app.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SiobhyB
approved these changes
Mar 4, 2024
Contributor
SiobhyB
left a comment
There was a problem hiding this comment.
LGTM, smoke tested the editor on both platforms and confirmed I spotted no regressions. 🚀
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Remove React Native bridge functions related to media collection.
Why?
These functions are no longer used, so we are removing them to clean up the bridge code.
How?
Remove bridge functions and related code.
Testing Instructions
The changes shouldn't affect the current version of the editor. For testing, we could just smoke testing the editor and observe that works as expected.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A