Resolve search block button text overlapping issue.#66868
Merged
gziolo merged 3 commits intoWordPress:trunkfrom Nov 22, 2024
Merged
Resolve search block button text overlapping issue.#66868gziolo merged 3 commits intoWordPress:trunkfrom
gziolo merged 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
6 tasks
Member
|
Tested at WordCamp Wrocław. Everything works as advertised. |
gziolo
approved these changes
Nov 22, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR addresses an issue with the "Search Block" where the button text overlaps when the "Change button position" is set to "Button Only" and the block width is adjusted to 25% in the block settings.
#66852
#66871
Why?
This PR is necessary to improve the display and functionality of the Search Block when specific settings are applied. Currently, setting the button position to "Button Only" and resizing the block width to 25% causes the button text to overflow, resulting in an inconsistent and undesirable UI.
How?
The PR resolves the issue by removing specific CSS styling that contributed to the overlapping of the button text. The removed styles were causing the button to not resize correctly within the limited width of the block.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Frontend in desktop Screen
Editor in Mobile Screen
Frontend in Mobile Screen