Navigation Link: Add "Open in new tab" toggle to navigation block sidebar

[Infinite-Null]

Fixes: #67246

What?

Adds the "Open in new tab" toggle option to the Navigation Link block's settings sidebar, making it accessible alongside other link settings.

Why?

Currently, the "Open in new tab" setting is only available within the link modal of the context menu, while all other link options are presented in the block settings sidebar. This inconsistent placement has confused editors trying to locate this commonly used option.

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: relic-se <ogrecooper@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[relic-se]

Thanks for getting on top of this, @Infinite-Null ! My only suggestion is that I feel the ToggleControl should be placed underneath "Link" rather than at the top of the Navigation Link block settings.

[Infinite-Null]

Thanks for getting on top of this, @Infinite-Null ! My only suggestion is that I feel the ToggleControl should be placed underneath "Link" rather than at the top of the Navigation Link block settings.

Hi @relic-se,

Thank you for the valuable suggestion! is this correct?

[relic-se]

Yes, that looks great. I think you've provided a quick, simple solution for this problem. All clear with me!

[t-hamano]

Sorry for the late reply.

The code looks good, let's wait for design feedback.

[jasmussen]

Should it be a simple checkbox to match what's inside the link dialog?

It doesn't seem valuable to have two different designs for this. Thanks for the PR!

[Infinite-Null]

Hi @jasmussen,
Thanks for the feedback 🙌! I’ve updated the PR to use a simple checkbox to match what’s inside the link dialog, ensuring consistency in design. Please review it at your convenience.

Screenshot:

[jasmussen]

Nice quick action. I'd omit the help text, though, the checkbox itself seems plenty descriptive, and by removing the help text you further ensure it's the same design.

[Infinite-Null]

Thanks for the feedback @jasmussen,
I have updated the PR and removed the help text:

[jasmussen]

Nice, works for me. I'll defer to others on the details. 👍 👍

[getdave]

We should probably apply the same to the Submenu block

[priethor]

We should probably apply the same to the Submenu block

We should check the interface of the Button block, as adding a link there is very different.