Separator: Surfacing the HTML markup control#70455
Conversation
…cedControls for HTML element selection
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @t-hamano, I have reverted the changes and moved |
| </ToolsPanelItem> | ||
| </ToolsPanel> | ||
| ) } | ||
| <InspectorControls group="advanced"> |
There was a problem hiding this comment.
While we could also use InspectorAdvancedControls to achieve the same result, I followed the approach used in the previous PR and implemented it using InspectorControls for consistency. Happy to adjust if there’s a preference for a different approach.
There was a problem hiding this comment.
Either way is fine since they have the same meaning, but it appears that InspectorAdvancedControls exists for backward compatibility. Therefore, the current approach of using InspectorControls seems to be fine.
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I support this PR, but I want to avoid moving the UI multiple times due to disagreements, as this creates cognitive load for users. Let's take a moment and wait for the additional feedback.
After much thought, let's merge this PR for now. See #70441 (comment)
* Refactor: Simplify InspectorControls structure and add InspectorAdvancedControls for HTML element selection * Refactor: Remove unused InspectorControls and related components from SeparatorEdit * Refactor: Replace InspectorAdvancedControls with InspectorControls for consistency Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: karmatosed <karmatosed@git.wordpress.org> Co-authored-by: amberhinds <alh0319@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
What?
Closes #70441
Reverts the HTML element control in the Separator block back to the Advanced Inspector panel to restore consistent UI patterns and improve overall usability.
Why?
In PR #70185, the HTML element control was moved from the Advanced Inspector to the top-level Settings panel to improve accessibility. However, this change created a significant usability regression.
How?
This PR reverts the UI changes from #70185 by:
HtmlElementControlback toInspectorAdvancedControlsTesting Instructions
<hr>and<div>optionsScreenshots or screencast