close
Skip to content

Fix: Focus outline width inconsistency in Site Editor#70614

Closed
Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Infinite-Null:fix/outline-navigation
Closed

Fix: Focus outline width inconsistency in Site Editor#70614
Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Infinite-Null:fix/outline-navigation

Conversation

@Infinite-Null
Copy link
Contributor

What?

Closes: #70613
Fix focus outline width inconsistency in Site Editor Navigation panel by adjusting padding from 5px to 1px.

Why?

The focus outline and selected item background in the Site Editor Navigation panel have inconsistent widths, creating visual misalignment. The focus outline doesn't properly align with the highlighted selection background, making the interface appear inconsistent.

How?

Updated the CSS calculation for the right positioning from -(24px + 5px) to -(24px + 1px), reducing the padding component from 5px to 1px while maintaining the 24px icon size. This ensures the focus outline width matches the selected item background width, creating consistent visual alignment in the navigation panel.

Testing Instructions

  1. Navigate to the WordPress admin dashboard
  2. Go to Appearance > Editor
  3. Select Navigation from the design options
  4. Select any one navigation item from list
  5. Observe the focus outline width compared to the selected/highlighted item background

Screenshots

Before After
Image Screenshot 2025-07-04 at 2 21 47 PM

@Infinite-Null Infinite-Null requested a review from ellatrix as a code owner July 4, 2025 09:02
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Jul 4, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Jul 4, 2025

Thanks for the PR! I think this issue needs to be considered not only in the navigation panel but also in the list view.

See #69201 for more details.

@t-hamano t-hamano closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus outline width inconsistency in Site Editor

2 participants