Fix: Focus outline width inconsistency in Site Editor#70614
Closed
Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fix: Focus outline width inconsistency in Site Editor#70614Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Thanks for the PR! I think this issue needs to be considered not only in the navigation panel but also in the list view. See #69201 for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes: #70613
Fix focus outline width inconsistency in Site Editor Navigation panel by adjusting padding from 5px to 1px.
Why?
The focus outline and selected item background in the Site Editor Navigation panel have inconsistent widths, creating visual misalignment. The focus outline doesn't properly align with the highlighted selection background, making the interface appear inconsistent.
How?
Updated the CSS calculation for the right positioning from -(24px + 5px) to -(24px + 1px), reducing the padding component from 5px to 1px while maintaining the 24px icon size. This ensures the focus outline width matches the selected item background width, creating consistent visual alignment in the navigation panel.
Testing Instructions
Screenshots