Shortcut keys for Notes submit#72864
Closed
karthick-murugan wants to merge 1 commit intoWordPress:trunkfrom
Closed
Shortcut keys for Notes submit#72864karthick-murugan wants to merge 1 commit intoWordPress:trunkfrom
karthick-murugan wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
I went with a slightly different direction - #72868. |
Contributor
Author
Shall I close this PR? |
Contributor
|
Since #72868 also includes E2E tests, let's proceed with #72868. @karthick-murugan Thanks for your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #72721
This PR adds keyboard shortcut support for submitting notes and note replies in the collaboration sidebar. Users can now submit notes by pressing
⌘ + Enter(Mac) orCtrl + Enter(Windows/Linux), which aligns with common patterns in many modern applications.Why?
Many apps let users submit forms using ⌘ + Enter or Ctrl + Enter, offering a faster, familiar workflow. Currently, users must click the submit button to post notes or replies, which slows them down. Adding keyboard submission improves efficiency and aligns with user expectations from platforms like GitHub, Slack, and Discord.
Testing Instructions
⌘ + Enter(Mac) orCtrl + Enter(Windows/Linux)Video
REC-20251031141637.mp4