close
Skip to content

Fix Dragging scroll thread collapse#73649

Closed
karthick-murugan wants to merge 1 commit intoWordPress:trunkfrom
karthick-murugan:drag-scroll-bar
Closed

Fix Dragging scroll thread collapse#73649
karthick-murugan wants to merge 1 commit intoWordPress:trunkfrom
karthick-murugan:drag-scroll-bar

Conversation

@karthick-murugan
Copy link
Contributor

What?

Closes #73547.

This PR fixes an issue where dragging the Notes sidebar scrollbar caused expanded note threads to collapse. The fix adjusts the thread-selection effect in Comments so the component stops collapsing threads when blockCommentId becomes temporarily null during sidebar scrolling.

Why?

Dragging the sidebar scrollbar caused the sidebar to collapse the currently open thread, even though the user was only scrolling.

This made long note threads very difficult to navigate using the scrollbar.

Testing Instructions

  1. Open a post and ensure the Notes sidebar has long threads.
  2. Expand a thread with multiple replies.
  3. Scroll using:
  4. mouse wheel → should remain open
  5. sidebar scrollbar drag → should remain open (previously collapsed)

Video

REC-20251128183331.mp4

@karthick-murugan karthick-murugan marked this pull request as ready for review December 1, 2025 04:44
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <karthickmurugan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra added [Type] Bug An existing feature does not function as intended [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Dec 1, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Jan 9, 2026

This should be resolved now. I'm going to close the PR.

@Mamaduka Mamaduka closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging the sidebar scroll bar collapses expanded note threads

3 participants