ToggleControl: Pass full props to the input element#74956
ToggleControl: Pass full props to the input element#74956oandregal merged 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Thank you for working on this @SirLouen. I did not tried this fix because I wrongly assumed if we were not passing the prop, and using some reference hack to inject it, there was some reason, well that does not seems to be case 😅
It seems like this fix is working well I'm not noticing regressions, so I think we should probably merge this fix instead of mine. Just going to cc @mirka in case there is additional context.
mirka
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix! Please add a changelog before merging.
|
I’m now seeing warnings in the console for the deprecated |
|
@stokesman Sorry about that! Fix in #75296. |
Co-authored-by: SirLouen <sirlouen@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Alternative to #74952
Why?
#74952 solves the problem as form validation requires sync processing.
But ultimately the problem is that
requiredis not being passed in first place. Why not passing?Maybe I'm missing something, but this was the first thing that came to my mind when I saw this trouble
Testing Instructions
Copied/pasted from #74952