Re-enable client-side media processing#75848
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
4 tasks
Contributor
|
I'll rebase now that I've merged #75817. |
The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test.
a59a7e9 to
e166fa9
Compare
ockham
approved these changes
Feb 24, 2026
Contributor
ockham
left a comment
There was a problem hiding this comment.
Can't say I'm super-familiar with this code and feature, but it seems to work in my cursory testing. Merging, so it can be part of GB 22.6 RC3 (which is supposed to have parity with WP 7.0 Beta 1, where CSMP is enabled).
ockham
added a commit
that referenced
this pull request
Feb 24, 2026
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: 3f5b13c |
adamsilverstein
added a commit
that referenced
this pull request
Feb 25, 2026
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Member
|
Load performance regressed after this PR, especially in the site editor test: https://codevitals.run/public/WordPress/gutenberg/metrics?metric=site-editor-firstBlock |
Contributor
|
The e2e test related to client-side media handling is failing on the Should we backport this PR to |
Contributor
|
This PR has no impact on the WP 7.0 release, but let's cherry-pick this to resolve a CI failure in the |
|
There was a conflict while trying to cherry-pick the commit to the wp/7.0 branch. Please resolve the conflict manually and create a PR to the wp/7.0 branch. PRs to wp/7.0 are similar to PRs to trunk, but you should base your PR on the wp/7.0 branch instead of trunk. |
t-hamano
pushed a commit
that referenced
this pull request
Feb 27, 2026
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Contributor
Since the automatic cherry-pick failed, I will do a manual cherry-pick in #75998. |
t-hamano
added a commit
that referenced
this pull request
Mar 2, 2026
* Client-side media processing: Disable in Gutenberg just for now (#75756) * Client-side media processing: Disable in Gutenberg just for now * Try to fix failing test * Update docblock Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> * Re-enable client-side media processing (#75848) * Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/compat/plugin/media.php) added in Client-side media processing: Disable in Gutenberg just for now #75756 that disabled client-side media processing by default in the Gutenberg pluginoriginal_image), thumbnail base filename correctness, and below-threshold no-op behaviorSplit out from #75817 per review feedback.
Test plan
-scaledsuffix andoriginal_imagemetadataadd_filter( 'wp_client_side_media_processing_enabled', '__return_false' )still works🤖 Generated with Claude Code