Admin UI: update font size for title and breadcrumbs to match#76452
Open
Admin UI: update font size for title and breadcrumbs to match#76452
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -39 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 59b20df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23008385942
|
Contributor
|
Thanks for this. It's a tricky one; I whole-heartedly support the PR and the motivation and examples are clear, but Pages example looks anemic. I believe Jay, already pinged, has been looking into this particular header component, so he may have the solution handy, so hopefully he can propose a font size/weight that threads the needle! |
Contributor
|
I agree that in the context of the current site editor page dimensions this title looks a bit small. In the extensible site editor experiment it works better, and could be improved further by tightening the padding values a tiny bit, e.g.: 
Perhaps we should seek to better align the experimental/non-experimental site editors? |
jameskoster
reviewed
Mar 13, 2026
Comment on lines
+9
to
+12
| font-family: var(--wpds-font-family-heading); | ||
| font-size: var(--wpds-font-size-lg); | ||
| font-weight: var(--wpds-font-weight-medium); | ||
| line-height: var(--wpds-font-line-height-lg); |
Contributor
There was a problem hiding this comment.
Could/should we use Text rather than styling manually? I think there's a variant that matches this style 1:1.
Member
Author
There was a problem hiding this comment.
Ah nice, didn't realise Text was already part of wp-ui. 👍
Member
Author
There was a problem hiding this comment.
Testing Text out with 1e43dfc
The Text produces the same size as CSS, but font-size gets overridden with 1.3em, and then it ends up being bigger than 15px:
I could not use h1/h2 which would solve it?
@jameskoster perhaps first best updating just with CSS variables, and then once styles are dialled in, we can switch to components? I noticed breadcrumbs has some @wordpress/components and one variable still so we could update it all at once. I reverted back to CSS in 568ff76.
I also see breadcumbs uses h1 for first element, while title is h2. They should probably match.
Contributor
That's a valid path forward, the padding here is quite big: 
I think that could be the path to unblock this, get it landed. An alternative is either a larger font size, or a heavier weight. From the code it looks like medium is applied, but it both looks semibold in the screenshots rather than medium (which is fine), but shouldn't it also be semibold or bold instead of medium? Medium seems mostly reserved for buttons rather than headings yes? Mostly asking to absorb, I've not strong feelings invested. No action item for now, but the font scale does feel like it could be a bit more organic from the values we have (11, 12, 13, 15, 20,32). Mainly, the difference between 11, 12 and 13 feels too small in terms of steps. As a quick experiment, extrapolating from 11 and 13, a more uniform might be: 
Not suggesting the above, but wondering if we can diversify a bit notably the multiple small ones. |
Member
Author
|
The current version of Breadcrumps is using a fixed value, so there could be a new fixed shared value that works in the header for now and is slightly bigger than |
Contributor
|
I think I saw a suggestion to use
I agree with you about the font scale. The current values are all informed by existing UI (mostly the editor). 11px is only included because of the all-caps label style, which is something there has been repeated negative feedback about. I'd like to see 16px included since it's a commonly recommended default size, and could work well for these headings. It could be a good moment to evaluate all of this. Tentative action items for this PR:
A mockup to demonstrate: 
|
59b20df to
1e43dfc
Compare
This reverts commit 1e43dfc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates title and breadcrumbs font sizes to match.
Titles are now slightly smaller, and breadcrumbs slightly larger.
Part of #76448
Why?
Consolidate font sizes so that there's is no visual "jump" between pages using breadcrumbs or a title in the header.
How?
Testing Instructions
Try breadcrumbs locally with the component:
...or just use Storybook added in:
Testing Instructions for Keyboard
Screenshots or screencast
Fonts
Before
After
Pages
Before
After