WP-NOW: Simplify multipart requests by dropping manually encoding#261
Merged
sejas merged 2 commits intoWordPress:trunkfrom May 15, 2024
Merged
Conversation
This was referenced May 13, 2024
bgrgicak
approved these changes
May 14, 2024
sejas
approved these changes
May 15, 2024
Collaborator
sejas
left a comment
There was a problem hiding this comment.
Nice!,
So, the helper library was messing up instead of solving the issue.
Thanks for trying it and creating the PR!
no-library-for-file-uplaod.mp4
I can deploy it tomorrow. I'll probably need some time to improve the GitHub action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Drop manually encoding multipart requests. This PR is a follow-up of #203.
Why?
This PR follows this discussion regarding the necessity of manually encoding multipart requests. Additionally, it addresses #259.
How?
fileUploadmiddleware to avoid modifying the request object.encodeAsMultiparthelper, since we don't need to process them differently (Playground CLI example).Testing Instructions
nvm use && npm install.nx preview wp-now start.http://localhost:8881/wp-admin).