Match thumbnail aspect ratio to singular view banner#1649
Closed
dd32 wants to merge 1 commit intoWordPress:productionfrom
Closed
Match thumbnail aspect ratio to singular view banner#1649dd32 wants to merge 1 commit intoWordPress:productionfrom
dd32 wants to merge 1 commit intoWordPress:productionfrom
Conversation
Change the wccentral-thumbnail-large image size from 926x160 to 926x418 so that its aspect ratio matches the wccentral-thumbnail-small (82x37) thumbnail used on the schedule listing. This ensures banner images are no longer cropped differently between the schedule listing and the singular WordCamp view. Fixes WordPress#1617 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Closing - submitted to wrong repo. Correct PR is on dd32/wordcamp.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wccentral-thumbnail-largeimage size from 926x160 (5.79:1 ratio) to 926x418 (2.22:1 ratio) to match thewccentral-thumbnail-smallthumbnail size (82x37, 2.22:1 ratio).Context
The schedule listing at
central.wordcamp.org/schedule/useswccentral-thumbnail-small(82x37) while the singular view useswccentral-thumbnail-large(926x160). These had very different aspect ratios (2.22:1 vs 5.79:1), causing banner images to appear cropped on the sides when shown as thumbnails.Fixes #1617
Test plan
functions.phpuses the updated dimensionswccentral-thumbnail-largecrop matches the aspect ratio ofwccentral-thumbnail-smallGenerated with Claude Code