close
Skip to content

[CLI] Run linter on php command changes#3349

Closed
Copilot wants to merge 2 commits intodraft-php-commandfrom
copilot/sub-pr-2641
Closed

[CLI] Run linter on php command changes#3349
Copilot wants to merge 2 commits intodraft-php-commandfrom
copilot/sub-pr-2641

Conversation

Copy link
Contributor

Copilot AI commented Mar 6, 2026

  • Fix TypeScript errors in run-cli.spec.ts: update process.exit mock parameter type from number | undefined to string | number | null to match Node.js's actual signature

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Contributor Author

Copilot AI commented Mar 6, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.cypress.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add CLI command to run PHP scripts [CLI] Run linter on php command changes Mar 6, 2026
@adamziel
Copy link
Collaborator

adamziel commented Mar 6, 2026

@copilot try again

Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 6, 2026

@copilot try again

Fixed the CI failure in 6a4f657. The TypeScript errors were caused by process.exit mock implementations using (code?: number) which is incompatible with the actual Node.js signature of (code?: string | number | null | undefined) => never. Updated all three occurrences to use (code?: string | number | null) with a proper numeric coercion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants