Expose pathAliases and rewriteRules from runCLI#3384
Closed
Conversation
When importing a site into Studio via streaming-site-migration, the recreated remote host directory structure may not have wp-admin directly in the document root. Custom rewrite rules let the caller remap URL paths to the actual filesystem layout so WordPress still boots correctly. pathAliases was already plumbed through RunCLIArgs but rewriteRules was hardcoded to the default WordPress set. This change adds rewriteRules to RunCLIArgs and BootRequestHandlerOptions, and appends any caller- provided rules after the built-in WordPress rewrite rules.
Collaborator
Author
|
ah, pathAliases is already exposed, we don't need this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When importing a site into Studio via streaming-site-migration, the recreated remote host directory structure may not have a
wp-admindirectory directly in the document root. Custom rewrite rules let the caller remap URL paths to the actual filesystem layout so WordPress still boots correctly.pathAliaseswas already threaded throughRunCLIArgsbutrewriteRuleswas hardcoded to the default WordPress set insidebootRequestHandler(). This change addsrewriteRulestoRunCLIArgsandBootRequestHandlerOptions, and appends any caller-provided rules after the built-in WordPress rewrite rules.Test plan
runCLI()programmatically with customrewriteRulesand verify they take effect