Closed
Conversation
Also use the blur event to commit invalid values allowing extending components like `NumberControl` to resolve the value on commmit.
7 tasks
|
Size Change: +166 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
6 tasks
Member
|
@stokesman, can we close this PR? The linked issue is marked as fixed - #33291. |
Contributor
Author
|
Thanks for asking George! I do feel this would still be an improvement but may not be possible with BC concerns. |
Member
|
Thanks for the update, @stokesman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping this drafted as it would be important to first correct the stepping behavior of
NumberControlso that it does not step to invalid values #34566.What
This PR enables consumers of
NumberControlto expect that values received by itsonChangehandler will be valid according to itsmin,max,stepandrequiredprops.It adds unit tests to cover the new behavior.
It also includes a small change to
RangeControlneeded to maintain its current behavior on top of the changed behavior ofNumberControl.Why
To fix #33291
How
Primarily (on a high-level) by changes to
NumberControlso that itonChangewith invalid valuesMuch of the changes required to support that were in
InputControlsince the behavior ofNumberControlis rooted there. The changes toInputControlmake it so that itonChangewith invalid values (like it already does for dirty values)commitonblur(like it already does for dirty values)onValidatebefore changes (whenisPressEnterToChangeisfalse)invalidateactionsTesting Instructions
will update…
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).