E2E: add site and widget editor supports for ensureSidebarOpened#45480
Merged
Mamaduka merged 2 commits intoWordPress:trunkfrom Nov 3, 2022
Merged
Conversation
|
|
7 tasks
Mamaduka
approved these changes
Nov 3, 2022
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Tests are passing on CI, and I re-run them one more. I think this looks good to merge 👍
Thank you, @dinhtungdu!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR add Site and Widgets Editor supports for the
ensureSidebarOpenedutility.Why?
Currently,
ensureSidebarOpenedonly supports the Blocks Editor. To test against Site or Widgets Editors, developers have to create custom utitlityHow?
This PR combines selectors of the setting button in Widgets and Site Editor (edit mode is supported) to make the utility works with all three editors.
Testing Instructions
N/a. Ensure E2E tests are passing. We're using a similar utility for WooCommerce Blocks here.