FormTokenField: handle disabled prop on internal Button#57187
Merged
FormTokenField: handle disabled prop on internal Button#57187
FormTokenField: handle disabled prop on internal Button#57187Conversation
andrewhayward
approved these changes
Dec 19, 2023
Contributor
andrewhayward
left a comment
There was a problem hiding this comment.
I was initially going to say it feels weird to include the 'remove' buttons at all if the control is disabled, but actually that feels more like read-only behaviour. So 🚀 – works for me.
Contributor
Author
|
Thanks @andrewhayward! |
|
Flaky tests detected in a9d29a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7283296905
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #23713
What?
Pass the
disabledprop to theButtoncomponent on selected tokesnWhy?
When
FormTokenFieldisdisabled, the buttons don't remove tokens because the click isn't handled. The buttons are still focusable though, which isn't ideal.How?
prop forwarding
Testing Instructions
FormTokenFieldstoryDisabledtotrue