close
Skip to content

52365: Title Bar shifts when switching between saved and save#57462

Closed
ghorivipul97 wants to merge 2 commits intoWordPress:trunkfrom
ghorivipul97:update/title_bar_shifts_when_switching
Closed

52365: Title Bar shifts when switching between saved and save#57462
ghorivipul97 wants to merge 2 commits intoWordPress:trunkfrom
ghorivipul97:update/title_bar_shifts_when_switching

Conversation

@ghorivipul97
Copy link
Contributor

What?

Modify Button style of Save which updating default font family.

Why?

When update default -global style then it's switch bar.

How?

Testing Instructions

  1. Open the Site Editor
  2. Edit the home template
  3. Open styles > typography > text
  4. Change the font and then change it back to original font selection. Notice the title bar.

@t-hamano t-hamano self-requested a review December 30, 2023 13:24
@t-hamano
Copy link
Contributor

Thanks for the PR, @ghorivipul97!

I think this PR is trying to solve #52295.

Unfortunately, I don't think it's possible to hardcode the minimum width of the Button. This is because the width of the button changes depending on the language.

Below is a screenshot when I changed the site language to Japanese. You can see that when the button means "Saved", it is much longer than in English.

I can't think of any good ideas at the moment, but I think we need an approach that doesn't depend on a particular width.

38c753dad477a81d3fc85b16bfe60d55.mp4

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Dec 30, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Apr 1, 2024

Sorry for the late review. This issue appears to have been resolved as part of #59134.

I would like to close this PR, but I appreciate your efforts.

@t-hamano t-hamano closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants