52365: Title Bar shifts when switching between saved and save#57462
Closed
ghorivipul97 wants to merge 2 commits intoWordPress:trunkfrom
Closed
52365: Title Bar shifts when switching between saved and save#57462ghorivipul97 wants to merge 2 commits intoWordPress:trunkfrom
ghorivipul97 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Contributor
|
Thanks for the PR, @ghorivipul97! I think this PR is trying to solve #52295. Unfortunately, I don't think it's possible to hardcode the minimum width of the Button. This is because the width of the button changes depending on the language. Below is a screenshot when I changed the site language to Japanese. You can see that when the button means "Saved", it is much longer than in English. I can't think of any good ideas at the moment, but I think we need an approach that doesn't depend on a particular width. 38c753dad477a81d3fc85b16bfe60d55.mp4 |
Contributor
|
Sorry for the late review. This issue appears to have been resolved as part of #59134. I would like to close this PR, but I appreciate your efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Modify Button style of Save which updating default font family.
Why?
When update default -global style then it's switch bar.
How?
Testing Instructions