Image block: Omit max width observer element in galleries#69601
Merged
Image block: Omit max width observer element in galleries#69601
Conversation
6 tasks
|
Size Change: +8 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
stokesman
commented
Mar 17, 2025
| clientId={ clientId } | ||
| blockEditingMode={ blockEditingMode } | ||
| parentLayoutType={ parentLayout?.type } | ||
| parentLayoutType={ layoutType } |
Contributor
Author
There was a problem hiding this comment.
This isn’t required for the fix and affects nothing at present. It just makes sense to pass the resolved value since otherwise the Image component would be getting undefined when inside a Gallery. It doesn’t matter, for now, in that particular case because everything it might affect is subordinate to allowResize that’s provided through context.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jupa8712. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Mar 19, 2025
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
This PR works well for me!
Not directly related to this PR, but I wonder if we should add the same check for other resizable blocks.
Example - The Site Logo block is (unintentionally) resizable in the stack layout:
Contributor
Author
|
Thanks for testing and reviewing!
It would seem appropriate for now. I imagine the end goal isn’t disabling the in-canvas resizing in flex layouts but making it work like the Spacer block which keeps it and applies the value(s) per the parent layout’s support specification. Ultimately it would be nice if all this could be assimilated into a supports API sort of like what #32502 was doing. I’m sure that’s quite an effort though. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…69601) Unlinked contributors: jupa8712. Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69566
When an Image block is inside a gallery, omits an element that may cause layout issues and is unnecessary in that context already.
Why?
How?
Modifies the existing condition for rendering the element to account for the Gallery block’s layout definition.
Testing Instructions
Open a post
Paste in this test markup:
Images in various containers including Gallery
For the first Image block and for one Image block in each container:
figure. Presence looks like this:Screenshots or screencast