Navigation block: fix submenu Escape key behavior#69837
Merged
Conversation
|
Size Change: +6 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 07142c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14287716831
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Apr 7, 2025
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the fix! This PR works very well for me.
Testing keyboard accessibility with screen reader:
1baacce029df89a60ed8ed6c5ea05355.mp4
Contributor
Author
|
Thanks for the review 🙇. I was glad to see your testing included third-level menus and with “Open on click” disabled. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Add coverage in e2e tests * Fix focus loss when pressing Escape from nested menu * Update e2e test for closing one menu level * Have Escape key close a single menu level at a time Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69834
When using the Escape key to close menus, this makes it only close one menu level at a time and focus the parent menu item.
Why?
When using the Escape key to close menus:
How?
previousFocusto the context (Interactivity API) of submenus. This makes each level have it’s own reference. Without this onepreviousFocusreference is shared by all levels and when set by a nested menu it overwrites the previous value causing it to be lost.stopPropagationcall to thekeydownhandler (when Escape key was pressed).Testing Instructions
Manually
Use the following HTML to create a Navigation with nested submenus:
HTML example
E2E
Screenshots or screencast