close
Skip to content

Icon: Add a new icon for "Post Comments Link"#70895

Closed
shrivastavanolo wants to merge 2 commits intoWordPress:trunkfrom
shrivastavanolo:icons/add-post-comments-link-icon
Closed

Icon: Add a new icon for "Post Comments Link"#70895
shrivastavanolo wants to merge 2 commits intoWordPress:trunkfrom
shrivastavanolo:icons/add-post-comments-link-icon

Conversation

@shrivastavanolo
Copy link
Contributor

@shrivastavanolo shrivastavanolo commented Jul 24, 2025

What?

Closes #40543

Proposes a new icon ( Icon design from #40543 by @t-hamano ) to better represent the Post comments link block.

Why?

The "Post Comments Link" block currently uses the same icon as the "Post Comments Count" block, which displays a number. This is unnatural for a link block, so a new icon should be created to better represent its purpose.

How?

A new icon, postCommentsLink, has been created and is now being used by the "Post Comments Link" block. This new icon is exported from the @wordpress/icons package and is defined in a new file post-comments-link.tsx. The icon is an SVG image with a specific design, as shown in the code.

Additionally, the packages/icons/src/index.ts file has also been updated to export the new postCommentsLink icon.

Testing Instructions

  1. Go to the post editor
  2. Search for the Comments Link block
  3. Observe the icon

Screenshots or screencast

Before

Screenshot 2025-07-24 at 4 33 18 PM

After

Image 24-07-25 at 4 08 PM

Screenshot 2025-07-24 at 4 12 01 PM Screenshot 2025-07-24 at 4 12 09 PM

Looking for some design feedback on this. Thanks!

@shrivastavanolo shrivastavanolo force-pushed the icons/add-post-comments-link-icon branch from c314089 to 2bfe679 Compare July 24, 2025 11:26
@shrivastavanolo shrivastavanolo marked this pull request as ready for review July 24, 2025 12:02
@github-actions
Copy link

github-actions bot commented Jul 24, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: [Package] Icons.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link

github-actions bot commented Jul 24, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shrivastavanolo <shreya0shrivastava@git.wordpress.org>
Co-authored-by: karmatosed <karmatosed@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: BenjaminZekavica <benjamin_zekavica@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano requested a review from a team July 25, 2025 08:03
@t-hamano t-hamano added Needs Design Feedback Needs general design feedback. [Package] Icons /packages/icons labels Jul 25, 2025
@t-hamano
Copy link
Contributor

@WordPress/gutenberg-design I'd love your feedback on whether this new icon makes sense to us.

The icons that include a comment in their name are as follows:

image

Should we at least align the icons on the left?

icon_alignment

@shrivastavanolo
Copy link
Contributor Author

Left alignment definitely looks cleaner. I've updated it accordingly. Attaching a screenshot for reference.
Screenshot 2025-07-25 at 3 38 45 PM
Screenshot 2025-07-25 at 3 38 36 PM

Thanks!

Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for this moving a bit too fast into being created without thinking if we should create it or not. I want to take us back to the issue a little for a while to consider as this is parts with other blocks, is having different icons the right path? We have to consider maintenance of each one and by being careful we do that before just adding. It might be, but we need to consider not just add.

As is being shown here even the actual icon hasn't been chosen yet or refined, so let's go back to the issue work it out there and we absolutely can find our path from that point.

For now, let's not add this but go back to the original issue and get a path there first. Thanks everyone for the work so far.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Icons /packages/icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon: Proposal to create a new icon for "Post Comments Link"

3 participants