Icon: Add a new icon for "Post Comments Link"#70895
Icon: Add a new icon for "Post Comments Link"#70895shrivastavanolo wants to merge 2 commits intoWordPress:trunkfrom
Conversation
c314089 to
2bfe679
Compare
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Apologies for this moving a bit too fast into being created without thinking if we should create it or not. I want to take us back to the issue a little for a while to consider as this is parts with other blocks, is having different icons the right path? We have to consider maintenance of each one and by being careful we do that before just adding. It might be, but we need to consider not just add.
As is being shown here even the actual icon hasn't been chosen yet or refined, so let's go back to the issue work it out there and we absolutely can find our path from that point.
For now, let's not add this but go back to the original issue and get a path there first. Thanks everyone for the work so far.




What?
Closes #40543
Proposes a new icon ( Icon design from #40543 by @t-hamano ) to better represent the Post comments link block.
Why?
The "Post Comments Link" block currently uses the same icon as the "Post Comments Count" block, which displays a number. This is unnatural for a link block, so a new icon should be created to better represent its purpose.
How?
A new icon,
postCommentsLink, has been created and is now being used by the "Post Comments Link" block. This new icon is exported from the@wordpress/iconspackage and is defined in a new filepost-comments-link.tsx. The icon is an SVG image with a specific design, as shown in the code.Additionally, the
packages/icons/src/index.tsfile has also been updated to export the newpostCommentsLinkicon.Testing Instructions
Comments LinkblockScreenshots or screencast
Before
After
Looking for some design feedback on this. Thanks!