Notes: Fix strange default sidebar animation#72710
Merged
Conversation
|
Size Change: 0 B Total Size: 2.37 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Oct 27, 2025
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I don't see any problem 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Thanks for testing, @Mamaduka! |
iqbal-web
approved these changes
Oct 27, 2025
|
Flaky tests detected in 11ed739. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18844209095
|
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: d96a59c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #72686
PR fixes the strange animation of the default sidebar when "Show Template" mode is engaged.
Unmounting the floating notes sidebar was triggering the animation; this could be a more general issue with the complementary area animation. The list view has a similar issue #69240.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screencast
CleanShot.2025-10-27.at.18.16.26.mp4