Fix: long unhyphenated text overflows the container#73711
Fix: long unhyphenated text overflows the container#73711Rishit30G wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| padding: $grid-unit-10; | ||
| } | ||
|
|
||
| .components-dropdown-menu__toggle { |
There was a problem hiding this comment.
We shouldn't use classnames from the components package. Instead we should add a specific classname in toggleProps of post template panel.
Wondering though if this should also be added (not in this PR) for the dropdown menu toggle. --cc @mirka
There was a problem hiding this comment.
Right, I think one could argue that this should be added to Button even.
I just noticed something wild though, which is that the non-default variants (e.g. primary) of Button have white-space: nowrap set, while the default variant does not 😅 I don't understand the reasoning for that choice, but in any case I think it'd be fine to add word-break: break-word to Button. It wouldn't affect variants that don't allow wrapping, and will result in better wrapping behavior for the variant that does allow it.
|
Thanks for the PR! Closing though since it was resolved by: #76071 |


What?
Fixes: #73707
Why?
This will help fix the issue where long, unhyphenated text overflows the container in the side panel where the author’s name appears.
Testing Instructions
To test in the post editor:
Screenshots or screencast