Connectors: Update page identifier to options-connectors#76142
Merged
jorgefilipecosta merged 4 commits intotrunkfrom Mar 4, 2026
Merged
Connectors: Update page identifier to options-connectors#76142jorgefilipecosta merged 4 commits intotrunkfrom
jorgefilipecosta merged 4 commits intotrunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.87 MB ℹ️ View Unchanged
|
4 tasks
Updates the Connectors screen to use the `options-connectors` page identifier, aligning with the Settings menu naming convention (options-general.php, options-writing.php, etc.). Changes: - Update package.json page identifier to "options-connectors" - Update script module data element ID in JavaScript - Update PHP filter hooks to match new naming - Update menu registration to remove Core's direct file entry
95ecd95 to
8864d09
Compare
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 4, 2026
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention used by other settings pages (`options-general.php`, `options-writing.php`, etc.). * Adds `src/wp-admin/options-connectors.php` as a direct admin screen file. * Adds a static submenu entry in `menu.php` at position 12 (after General). * Removes `_wp_connectors_add_settings_menu_item()` and its `admin_menu` hook from `connectors.php`. * Updates the `script_module_data` filter from `connectors-wp-admin` to `options-connectors-wp-admin`. Synced from WordPress/gutenberg#76142. Developed in #11157. Follow-up to [61749], [61824]. See #64730. Props jorgefilipecosta, gziolo. Fixes #64790. git-svn-id: https://develop.svn.wordpress.org/trunk@61825 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 4, 2026
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention used by other settings pages (`options-general.php`, `options-writing.php`, etc.). * Adds `src/wp-admin/options-connectors.php` as a direct admin screen file. * Adds a static submenu entry in `menu.php` at position 12 (after General). * Removes `_wp_connectors_add_settings_menu_item()` and its `admin_menu` hook from `connectors.php`. * Updates the `script_module_data` filter from `connectors-wp-admin` to `options-connectors-wp-admin`. Synced from WordPress/gutenberg#76142. Developed in WordPress/wordpress-develop#11157. Follow-up to [61749], [61824]. See #64730. Props jorgefilipecosta, gziolo. Fixes #64790. Built from https://develop.svn.wordpress.org/trunk@61825 git-svn-id: http://core.svn.wordpress.org/trunk@61112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
|
It needs to be re-tested with the latest changes applied in WP core 
|
gziolo
approved these changes
Mar 4, 2026
Member
gziolo
left a comment
There was a problem hiding this comment.
Maybe it's expected to work this way so in that case feel free to land it.
Member
Author
I think it was some temporary issue in your local build? I tested and it seems to work against trunk and the end to end tests are also passing. If the issue is persisting just let me know and I will debug further. |
|
There was a conflict while trying to cherry-pick the commit to the wp/7.0 branch. Please resolve the conflict manually and create a PR to the wp/7.0 branch. PRs to wp/7.0 are similar to PRs to trunk, but you should base your PR on the wp/7.0 branch instead of trunk. |
Member
It looks like it was because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Connectors screen to use the
options-connectorspage identifier, aligning with the Settings menu naming convention used by other settings pages (options-general.php,options-writing.php, etc.).This change prepares Gutenberg to work with Core's direct file URL pattern (
/wp-admin/options-connectors.php).Changes
routes/connectors-home/package.jsonpage identifier tooptions-connectorsdefault-connectors.tsxdefault-connectors.phpto useoptions-connectors-wp-adminload.phpto use new slug and remove Core's direct file entryTest plan