Performance lab playground integration Fixed#2280
Performance lab playground integration Fixed#2280iqbal-web wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Performance Lab Playground Integration is not working
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@iqbal-web Why does this fix the issue? Here's Playground with the You can see that it loads with Performance lab as expected. The changes you've introduced here just remove slash escapes, which shouldn't impact the resulting parsed JSON in any way. That said, it would indeed be good to remove those slashes since they aren't needed. When I load up
I also see validation issues in JSON Schema Validator: https://www.jsonschemavalidator.net/s/smWcDkog Perhaps this is why WordPress.org isn't showing the Preview button? |
When exploring wordpress plugins, Gutenberg only has which live preview that is working. So I checked the blueprint JSON file here and found some inconsistencies. So I update it like Gutenberg's current use. https://github.com/WordPress/gutenberg/blob/trunk/assets/blueprints/blueprint.json
Switch my pr, then run the validation. It will be fixed then.
|

Current blueprint not working. In this Pr, update it.
For Test: Playground Builder
Fixed #2279