close
Skip to content

Only retrieve upload related information when user can upload#3569

Closed
JanThiel wants to merge 1 commit intoWordPress:trunkfrom
JanThiel:56815_avoid_fs_calls_in_theme_json_parsing
Closed

Only retrieve upload related information when user can upload#3569
JanThiel wants to merge 1 commit intoWordPress:trunkfrom
JanThiel:56815_avoid_fs_calls_in_theme_json_parsing

Conversation

@JanThiel
Copy link

@JanThiel JanThiel commented Nov 4, 2022

Only retrieve upload related information for the theme.json resolver when user can actually upload

Trac ticket: https://core.trac.wordpress.org/ticket/56815


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Only retrieve upload related information when user can actually upload
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JanThiel, this looks like a solid solution to me. I've added a test to verify its correct behavior via #3588 (the production code solution is the same as here).

@felixarntz
Copy link
Member

@felixarntz felixarntz closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants