Formatting: Preserve '=' characters in add_query_arg() values#9822
Formatting: Preserve '=' characters in add_query_arg() values#9822himanshupathak95 wants to merge 3 commits intoWordPress:trunkfrom
add_query_arg() values#9822Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
34c6edd to
fe90565
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/50279
This PR improves the regex in
add_query_arg()to only strip the=signfor truly empty values (e.g.,
foo=→foo), while preserving valid=characters that appear inside query values (such as Base64 padding
xxxxx==).#=(&|$)#to/((?<=^|&)[^=]+=)(&|$)/to ensure onlyempty values are matched.
=.