[RNMobile] Improve UI of error boundary component#59823
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
Contributor
Author
|
@osullivanchris let me know if you have any thoughts/feedback about the UI changes. In the meantime, I'm going to merge this PR so it's included in the next GBM version (being cut tomorrow March 14th, 2024). |
|
Hey looks good. Some thoughts (none of which are blockers)
|
Contributor
Author
|
Thanks @osullivanchris for the feedback 🙇 ! I'll address this in a separate PR.
The text is wrapped based on the device's width, so I don't think there's an attribute to avoid a single ophan word in the last line. To achieve this, we'd need to perform different layout calculations, so not sure if it's worth the effort for a screen that (hopefully) not many users will see. WDYT? Alternatively, we could break the line to ensure there's two words in the last line. But this would imply setting a fixed width so the rest of the content fits a similar layout. I.e. the second paragraph has a similar width.
Good point. I'm not sure if the GitHub label |
Member
|
Hey @fluiddot 👋 it appears the usage of |
Contributor
Author
Good observation. I'll take a look and see if we can use the new format. Since we transform SASS code, I'm not sure if importing the |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR is a follow-up of #59221. Update the UI of the Error Boundary component that is displayed in editor-level exceptions.
Why?
This enhancement will provide a better experience when the user encounters editor-level exceptions.
How?
ErrorBoundarycomponent, located in the editor package.Warningcomponent as the design of theErrorBoundarycomponent is now custom.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
iPhone:
iPad:
Android: