[RNMobile] Update UI of error boundary component#59859
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 3e80db8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8278057027
|
geriux
approved these changes
Mar 14, 2024
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! I've tested on both iOS (iPhone/iPad) and Android 🚀
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Update title of error boundary component * Update dark mode colors of error boundary component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR follows up #59823.
Update the UI of the error boundary component, specifically, to improve styling when using dark mode.
Note
For Copy Review:
The texts were introduced in #59823. We are seeking for review in the following elements:
Thanks 🙇 !
Why?
This is an enhancement based on design feedback.
How?
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
iPhone:
iPad: